- - - -

AGOS/TODOAGOS/TODO

 TODO List Name AGOS Engine TODO Technical Contact(s) AGOS Engine Team Subsystem Engine

## Personal Nightmare

• Add support for fading effects used for transitions between day and night, in the Amiga and Atari ST versions.
• Add support for palette differences (i.e. inventory icons), in the Amiga and Atari ST versions.
• Fix charset rendering to match original PC version exactly, squeezing character where required.
• Improve sound support, especially the handling of appended and queued sounds. The introduction sequence (in Amiga/AtariST ports) of demo and full version, is the best point for testing.
• Using the 'Wait' command passes by far too quickly, and requires a work around. This problem occurs in the original game, when used on modern systems, due to the speed increase.

## Elvira 1

• Add support for the 'INSTR.DAT' AdLib instrument bank in the DOS version.
• Add support for music in Atari ST version (The format is unknown). The location of the music data is unknown.

## Elvira 2

• Add support for the 'INSTR.DAT' AdLib instrument bank in the DOS version.
• Add support for music in Atari ST version (The format is unknown). The music data is stored in 'xtune.pkd' files, and not compressed.
• Add support for AdLib sound effects in the DOS version, which are stored in the 'mylib.fxb' file.

## Waxworks

• Add support for AdLib sound effects in the DOS version, which are stored in the 'wax.fxb' file.

## Simon the Sorcerer 1

• Add support for Desktop Tracker format used for music in the Acorn disk version.
• Add support for the 'mt_fb.ibk' AdLib instrument bank in DOS versions.

## Simon the Sorcerer 2

• Add support for language files used by Amiga and Macintosh versions.
• Fix minor glitch in the trail shown on the first map, when Simon is riding the Lion to the Goblin's Camp. The minor glitch occurs, as the next location starts blinking, slightly too much background is been restored for some reason.

## Feeble Files

• Fix occasional glitch when scrolling text in Oracle interface. See this series of screenshots from the DIRECTIVE CHARTER article. (It happens in other places as well.) This is actually not a bug in the Simon engine, but rather a problem with the automatic calculation of dirty rects that we use to speed up full screen updates in some engines. Maybe the checksum algorithm is more likely to fail when there are only two colors involved?

### Some observations about the missing line breaks

(This text is kept for historical purposes. The line break bug should be fixed now.)

In the article titled THE COMPANY, only the first line is broken. The subsequent lines are not. The reason for this can be found in showmessage_print_char(): Every time an end of word (character codes 0, 10 or 32) appears, the function will check if the currently buffered word fits on the line or not:

    } else if (chr == 0 || chr == ' ' || chr == 10) {
uint count = (getGameType() == GType_FF) ? _printCharPixelCount + 1 : _printCharPixelCount;
if (_printCharMaxPos - _printCharCurPos >= count) {
_printCharCurPos += _printCharPixelCount;


The test checks if the remaining space on the line is larger than the length of the buffered word, i.e. if the test succeeds the word will fit. In this case, _printCharMaxPos is always 360.

At the first line break, _printCharCurPos is 325 and count is 40. The word does not fit, and therefore the line is broken.

Where the second line break should be, _printCharCurPos is 366 and count is 25. At first glance it looks like the test will fail, because the remaining space is negative. However, we're using unsigned variables, so what at first apperas to be a small negative value is actually a large positive one.

So how did this happen? Shouldn't the line have been broken at the previous word? No, in fact it should not. At that point, _printCharCurPos is 327 and count is 32. The word fits, just barely, and _printCharCurPos is increased to 358. Problem is, the line break check is triggered, here as almost always, by a space. And in that case the width of that space will also be added to _printCharCurPos, bringing it up to 366.

There are several possible fixes. A few that come to mind:

• Change the variables from unsigned to signed.
• Check for overflow before adding the width of the space. (This may be what it's trying to do already by checking if _printCharCurPos == _printCharMaxPos.)
• Rewrite the test so that signedness doesn't matter, e.g. if (_printCharCurPos + count < _printCharMaxPos)

Oddly enough, the original does use unsigned variables, and take none of these precautions. Is it possible that the compiler Adventure Soft used behaved differently (buggily?), or are we missing some subtle detail...?