Difference between revisions of "GUI Themes/TODO"

Latest revision as of 19:13, 11 March 2016

TODO List
Name	GUI Themes TODO
Technical Contact(s)	The ScummVM Team
Subsystem	Generic

We plan to implement a new GUI look & feel in ScummVM, roughly based on the new look of our web site. Some concept drafts of the new look can be found here: http://kressline.de/wip/scummvm/

To Do

General

Add tab-focus support, i.e. make it at least possible to use the "tab" key (and also "shift-tab" to cycle through the edit fields.
Even nicer would be general "tab cycle" support, allowing tab to cycle the focus for all items where it makes sense (buttons, checkboxes, etc.), to make the GUI fully keyboard controllable
SPEED: The GUI is relatively sluggish these days on my 1.5 GHz PowerBook :-/. I'll try to list some bottle necks and possible solutions:
- A lot of time is spent in ThemeModern::openDialog for dimming the screen.
  - The code calls a function pointer for each pixel of the screen, which results in code which the compiler can't properly optimize, essentially doing a couple hundred thousand tight read-call-write ops, which can't be inlined / improved upon.
  - Better: change _dialogShadingCallback to not work on a single pixel but on the whole better
  - Even better: Get rid of the _system->RGBToColor / _system->colorToRGB which are terrible for performance, too (can't be inlined). So, at least provide a 555 / 565 color mode version, which works efficient on targets using these color modes, and only fall back to the OSystem API if an unsupported color mode is in use
Implemented better layouting code. It should be possible to layout widgets in a grid (typical example: a 2 by n "grid", each row contains a label on the left side (to be right aligned) and a widget on the right side (to be left aligned).
Change the monolithic DrawStep struct into a class hierarchy. To this end, we probably should also change the XML format (which sadly closely mirrors this monolithic struct). Namely, replace the <drawstep> element by one element for each kind of drawstep. In each of these specialized "drawsteps", allow only those attributes that make sense.

Widgets

EditableWidget: Make it possible to specify a min/max length for the text
EditableWidget: Let setEditString filter the string it gets
EditableWidget: Right now, custom filtering requires the user to subclass; it would be nice if there was simply a "validator hook" or so. Maybe take some inspiration from Java's Swing in this matter.
List widget
- get mock-up from Krest
- Glitches when entering very long strings. The cursor overlaps the scrollbar. Possibly the scroll bar width should be automatically added to the right-side paddings, but I don't have the time to experiment with it right now.
PopUp widget (aka drop-down list)
- get mock-up from Krest
Scrollbar widget - The handle leaves trails in 320xY resolution. Possibly, the shadow of the handle is drawn too wide.
- Can't replicate in latest git master. Fixed by 1b2485f4af2010f262bd4f6e149a8c2d96b893cc?
Add a new "BoxWidget" / "GroupBoxWidget", which can be used to group other widgets
- This widget makes it easy to group widgets and control them together; e.g. disable the box widget, and all children get disabled, too
- Here is the equivalent of this control in Qt: http://doc.trolltech.com/4.3/widgets-groupbox.html
- (optionally) draws a border around itself
- (optionally) draws a title
- The ideal version of this would also support a checkbox in the title, and would automatically disable/enable all contained widgets if the checkbox gets activated (this is also demonstrated in the above Qt example)
- Clearly this widget would be of great use for the options dialogs, for the "Override XYZ" checkboxes
ButtonWidget: Allow drawing the 'default' button in a visually distinct way

Wizards

To make ScummVM as friendly as possible, we would like to introduce wizards that would help with essential tasks.
No Games Wizard: when there are no games in the config file, a wizard will come up saying something like

Welcome to ScummVM!

Please tell us where your point and click games can be found:

Path Edit Box

"Find My Games" button (uses Mass Add)

"Cancel Wizard" button, "Don't show again" Checkbox

Rare game options wizard: it was suggested that we implement a wizard to tell the user about rare options such as dithering in SCI games. For example, when an SCI0 game is added either directly or through mass add, we could show:

You have added an SCI0 game. This game can use the 'undithering' option to enhance the original look.

Checkbox "Turn this feature on"

Remember that you can turn this feature on or off through the XXXX tab.

OK button.

Dialogs

About dialog
- looks bad. Probably add some shadows and text padding
- fix glitch at the top of the dialog where part of the characters get stuck (see FIXME in about.cpp)
- [Classic theme] Text seems to be drawn over the dialog frame. At least at the top of the dialog.
- The grey text (color 2, kStateDisabled) is hard to read in both the new and the classic theme.
  - Reported as [Bug #5833]. Fixed in Modern by fee19d. Fix for classic still needed? i.e. make lighter there as background is black (as opposed to Modern, which has almost white background).
- Add a "fade" effect for the top/bottom text lines
- Maybe prerender all of the text into another surface, and then simply compose that over the screen surface in the right way.
Options dialog
- There is currently no way to unset/reset-to-default the path settings from the GUIsettings.
  - To this end. maybe add an (optional) "reset to default" button to the browser dialog. (This would save space in the options dialog)
  - Alternatively, add "Reset to Default" buttons to each path setting, possible similar to the one used with the soundfont (which is a rather too cryptic, IMO)
- Several texts, e.g. vcMusicText, have their alignment set to kTextAlignRight, but are still drawn as left-aligned.
- Add ability to adjust debuglevel (int). Useful for command line less ports i.e. Android.
Engine Options Dialog
- Currently only bool (checkbox) options are supported. Add support for int (slider) options. Needed for:
  - walkspeed (int)
  - gfx_details (int - SWORD2)
  - t7g_speed (int - GROOVIE)
- reverse_stereo (bool - SWORD2) is also currently missing. Make this a global option as it is likely to apply to a number of engines?
The sliding action of the debug console takes a lot more CPU now than it used to. On my 450 MHz P3, I don't even see it slide in 2x mode. It seems to appear/disappear all at once.
File browser dialog
- Right now we "visualize" that an entry is a folder/directory by appending a slash "/" to the name. This is not really intuitive for non-Unix users. Maybe we could add small file / directory icons? And maybe also an up-arrow for the "up" button.

Fonts

The BDF fonts can have characters that are both wider and taller than expected. For instance, the letter Ã… extends one pixel above the top of the line. This can lead to glitches since we update the screen based on font height and character width, not bounding boxes. The List widget is one example of this.
~~Antialiased fonts~~
- This could be tricky, since the BDF fonts are bitmaps. Is it even possible, within this format, to store the alpha channel needed (?) to represent an anti-aliased glyph? One possibility might be to store a larger version of the font and scale it down to the desired size, but that seems wasteful.
  - ~~BDF fonts aren't suitable here since they're 1bpp. It could be done if font data would be 8bpp and thus, contain just the alpha channel, i.e. shades of gray which will be blended on rendering stage.~~
  - It's *still* possible to use 1bpp fonts for antialiasing, by implementing oversampling: By downscaling a 4x fold or 8x too big character, one can compute & render the antialiased output on the fly -- this worked even on some old 90 MHz PowerPC Macs, so it should be doable. Main concern would be memory usage, and the need to have a big version of all fonts around. Or we switch to a vector based font system (TrueType plus Freetype), at the cost of resources and possibly some portability -- we would have to research this a bit. Another advantage of using FreeType: Unicode support in the GUI would be possible.

Collaborative work with the OpenUsability Project

Given that usability is one of the primary driving forces behind the design of user interfaces, it seems logical to pay close to attention to it while redesigning ScummVM's GUI.

The OpenUsability project (http://openusability.org/) provides usability consulting and advice for open sourced applications. It would be a sensible opportunity to contact them, seeking assistance to improve ScummVM in the usability front.

Some ideas about theme caching

Solution will look something like this:

 ./scummvm --gui-theme=classic  --create-gui-cache 320x200

you get classic-320x200.tcc file

 ./scummvm --gui-theme=classic  --create-gui-cache 320x240

you get classic-320x240.tcc file

Then concatenate the two and probably dump it into C array. Porters should do that by themselves for all resolutions supported by their platform. I.e. we have generic XxY theme, and all specific resolutions are derived from it.

tcc (theme cache) file format

This theme cache will be plainly a dump of all evaluated variables from HashMap. They will be loaded with loadAll() method in HashMap.

 'RESL', length, "320x200", number of vars, dumped vars

dumped vars are:

 "varname", int16 value,...

This format will let easily concatenate several generated theme cache files.

Probably there will be some optimisations in loadAll() method, which will malloc one big chunk of those vars, and since we have their keys as const char *, then it can alloc one big chunk for variables name as well and then pass pointers inside of it to respective members. Of course, that will be specially flagged as it will not be possible to free() any of those chunks deliberately.

@@ Line 1: / Line 1: @@
+{{Infobox_TODO|
+taskname=GUI Themes TODO|
+techcontact=The ScummVM Team|
+subsystem=Generic|
+}}
 We plan to implement a new GUI look & feel in ScummVM, roughly based on the
 new look of our web site. Some concept drafts of the new look can be found here:
-http://www.thekrest.de/wip/scummvm/
+http://kressline.de/wip/scummvm/
 See also [[GUI Themes/Specs|specs]]
@@ Line 15: / Line 21: @@
 *** Better: change _dialogShadingCallback to not work on a single pixel but on the whole better
 *** Even better: Get rid of the _system->RGBToColor / _system->colorToRGB which are terrible for performance, too (can't be inlined). So, at least provide a 555 / 565 color mode version, which works efficient on targets using these color modes, and only fall back to the OSystem API if an unsupported color mode is in use
+* Implemented better layouting code. It should be possible to layout widgets in a grid (typical example: a 2 by n "grid", each row contains a label on the left side (to be right aligned) and a widget on the right side (to be left aligned).
+* Change the monolithic DrawStep struct into a class hierarchy. To this end, we probably should also change the XML format (which sadly closely mirrors this monolithic struct). Namely, replace the <drawstep> element by one element for each kind of drawstep. In each of these specialized "drawsteps", allow only those attributes that make sense.
 === Widgets ===
@@ Line 20: / Line 28: @@
 * EditableWidget: Let setEditString filter the string it gets
 * EditableWidget: Right now, custom filtering requires the user to subclass; it would be nice if there was simply a "validator hook" or so. Maybe take some inspiration from Java's Swing in this matter.
-* ScrollBarWidget: Add auto-repeat: if user clicks & holds on one of the arrows, then after a brief delay, it should start to contiously scroll.
 * List widget
 ** get mock-up from Krest
@@ Line 26: / Line 33: @@
 * PopUp widget (aka drop-down list)
 ** get mock-up from Krest
-* Scrollbar widget
+* Scrollbar widget - The handle leaves trails in 320xY resolution. Possibly, the shadow of the handle is drawn too wide.
-** The handle of the scrollbar widget leaves trails in 320xY resolution. Possibly, the shadow of the handle is drawn too wide.
+** Can't replicate in latest git master. Fixed by 1b2485f4af2010f262bd4f6e149a8c2d96b893cc?
 * Add a new "BoxWidget" / "GroupBoxWidget", which can be used to group other widgets
 ** This widget makes it easy to group widgets and control them together; e.g. disable the box widget, and all children get disabled, too
@@ Line 34: / Line 41: @@
 ** (optionally) draws a title
 ** The ideal version of this would also support a checkbox in the title, and would automatically disable/enable all contained widgets if the checkbox gets activated (this is also demonstrated in the above Qt example)
-** If we ever add radio buttons, then those could be grouped via a GroupBoxWidget, too
 ** Clearly this widget would be of great use for the options dialogs, for the "Override XYZ" checkboxes
+* ButtonWidget: Allow drawing the 'default' button in a visually distinct way
+=== Wizards ===
+* To make ScummVM as friendly as possible, we would like to introduce wizards that would help with essential tasks.
+* No Games Wizard: when there are no games in the config file, a wizard will come up saying something like
+Welcome to ScummVM!
+Please tell us where your point and click games can be found:
+Path Edit Box
+"Find My Games" button (uses Mass Add)
+"Cancel Wizard" button, "Don't show again" Checkbox
+* Rare game options wizard: it was suggested that we implement a wizard to tell the user about rare options such as dithering in SCI games. For example, when an SCI0 game is added either directly or through mass add, we could show:
+You have added an SCI0 game. This game can use the 'undithering' option to enhance the original look.
+Checkbox "Turn this feature on"
+Remember that you can turn this feature on or off through the XXXX tab.
+OK button.
 === Dialogs ===
-* Add a new "options" dialog which is used by all frontends: for this, we'd agree on a hotkey used in all engines to invoke that dialog; it would sport settings for the volume, graphics, paths, etc.; it would co-exist with the engines "native" option dialogs. The about dialog would be reachable from here, too, as well as a quit button. Justification: This ensures that all settings are really reachable from all of the engines, which is not the case currently. Problem: It's not fully clear to me how to "best" deal with global vs. local settings here...
 * About dialog
 ** looks bad. Probably add some shadows and text padding
@@ Line 44: / Line 72: @@
 ** [Classic theme] Text seems to be drawn over the dialog frame. At least at the top of the dialog.
 ** The grey text (color 2, kStateDisabled) is hard to read in both the new and the classic theme.
+*** Reported as {{Tracker|id=5833}}. Fixed in Modern by fee19d. Fix for classic still needed? i.e. make lighter there as background is black (as opposed to Modern, which has almost white background).
 ** Add a "fade" effect for the top/bottom text lines
 ** Maybe prerender all of the text into another surface, and then simply compose that over the screen surface in the right way.
-* Chooser aka Add game dialog
-** [Classic Theme] Adjust size and position of the chooser to Launcher
 * Options dialog
 ** There is currently no way to unset/reset-to-default the path settings from the GUIsettings.
@@ Line 53: / Line 80: @@
 *** Alternatively, add "Reset to Default" buttons to each path setting, possible similar to the one used with the soundfont (which is a rather too cryptic, IMO)
 ** Several texts, e.g. vcMusicText, have their alignment set to kTextAlignRight, but are still drawn as left-aligned.
-** [Classic Theme] Adjust size and position of the "Options" dialog to Launcher
+** Add ability to adjust debuglevel (int). Useful for command line less ports i.e. Android.
-** It would be nice if you could select theme from the GUI. The "Graphics" tab, perhaps?
+* Engine Options Dialog
-* Edit game dialog
+** Currently only bool (checkbox) options are supported. Add support for int (slider) options. Needed for:
-** [Classic Theme] Adjust size and position of the "Edit game" dialog to Launcher
+*** walkspeed (int)
+*** gfx_details (int - SWORD2)
+*** t7g_speed (int - GROOVIE)
+** reverse_stereo (bool - SWORD2) is also currently missing. Make this a global option as it is likely to apply to a number of engines?
 * The sliding action of the debug console takes a lot more CPU now than it used to. On my 450 MHz P3, I don't even see it slide in 2x mode. It seems to appear/disappear all at once.
 * File browser dialog
-** Add a "show hidden files" checbox
 ** Right now we "visualize" that an entry is a folder/directory by appending a slash "/" to the name. This is not really intuitive for non-Unix users. Maybe we could add small file / directory icons? And maybe also an up-arrow for the "up" button.
 === Fonts ===
 * The BDF fonts can have characters that are both wider and taller than expected. For instance, the letter Ã… extends one pixel above the top of the line. This can lead to glitches since we update the screen based on font height and character width, not bounding boxes. The List widget is one example of this.
-* Antialiased fonts
+* <s>Antialiased fonts</s>
-** This could be tricky, since the BDF fonts are bitmaps. Is it even possible, within this format, to store the alpha channel needed (?) to represent an anti-aliased glyph? One possibility might be to store a larger version of the font and scale it down to the desired size, but that seems wasteful.
+** <s>This could be tricky, since the BDF fonts are bitmaps. Is it even possible, within this format, to store the alpha channel needed (?) to represent an anti-aliased glyph? One possibility might be to store a larger version of the font and scale it down to the desired size, but that seems wasteful.</s>
-*** BDF fonts aren't suitable here since they're 1bpp. It could be done if font data would be 8bpp and thus, contain just the alpha channel, i.e. shades of gray which will be blended on rendering stage.
+*** <s>BDF fonts aren't suitable here since they're 1bpp. It could be done if font data would be 8bpp and thus, contain just the alpha channel, i.e. shades of gray which will be blended on rendering stage.</s>
-*** Fingolfin says: It's *still* possible to use 1bpp fonts for antialiasing, by implemnting oversampling: By downscaling a 4x fold or 8x too big character, one can compute & render the antialiased output on the fly -- this worked even on some old 90 MHz PowerPC Macs, so it should be doable. Main concern would be memory usage, and the need to have a big version of all fonts around. Or we switch to a vector based font system (TrueType plus [http://www.freetype.org/index2.html Freetype]), at the cost of resources and possibly some portability -- we would have to research this a bit. Another advantage of using FreeType: Unicode support in the GUI would be possible.
+*** <s>It's *still* possible to use 1bpp fonts for antialiasing, by implementing oversampling: By downscaling a 4x fold or 8x too big character, one can compute & render the antialiased output on the fly -- this worked even on some old 90 MHz PowerPC Macs, so it should be doable. Main concern would be memory usage, and the need to have a big version of all fonts around. Or we switch to a vector based font system (TrueType plus [http://www.freetype.org/index2.html Freetype]), at the cost of resources and possibly some portability -- we would have to research this a bit. Another advantage of using FreeType: Unicode support in the GUI would be possible.</s>
+=== Collaborative work with the OpenUsability Project ===
+Given that usability is one of the primary driving forces behind the design of user interfaces, it seems logical to pay close to attention to it while redesigning ScummVM's GUI.
+The OpenUsability project (http://openusability.org/) provides usability consulting and advice for open sourced applications. It would be a sensible opportunity to contact them, seeking assistance to improve ScummVM in the usability front.
 == Some ideas about theme caching ==
@@ Line 96: / Line 130: @@
 Probably there will be some optimisations in loadAll() method, which will malloc one big chunk of those vars, and since we have their keys as ''const char *'', then it can alloc one big chunk for variables name as well and then pass pointers inside of it to respective members. Of course, that will be specially flagged as it will not be possible to free() any of those chunks deliberately.
-== Launcher hints ==
-On June 27th 2007 on #scummvm there was a discussion about implementing launcher hints to our detector.
-The main idea behind this is that enignes will hint launcher on available per-game options. Say, it will provide lists of languages, supported sound formats. Also this could be used for those rarely used options which we miss now in GUI, such as turning on or off copy protection or seceltion of different intro.
-It would be wise if a plugin is run when user hits 'Edit Game' button. Then it returns back a string in a special format. Current format is this:
-  launheropts=langs:(en,it,es,de),res:(2x),audio:(pcspk,adlib,midi),copyprot:(true),aspect:(false)
-Above mentioned example will populate language selection pop-up list with 4 languages, will tell that game runs in 640xY mode, supports 3 formats of audio, has ability to show copy protection screen(s) which are disabled by default and disables aspect ratio correction control.
-List of rarely used options which aren't reflected in GUI:
-* cdrom
-* joystick_num
-* alsa_port (or any other midi driver config stuff, there is an open FR for adding better MIDI config options, too, of course)
-* tempo (do we still need/want that, anyway?)
-* midi_gain
-* copy_protection
-* demo_mode
-* alt_intro
-List of values which are currently showed in GUI:
-* Language
-* Platform (do we really need to allow user to change that?)
-* Graphics mode (640x480 games with 2x selected now behave incorrectly)
-* Render mode (only few games support CGA or Hercules rendering)
-* Aspect ratio (FM-TOWNS games run in 320x240, NES MM doesn't use aspect correction too)
-* Music driver
-* Text and speech (for subtitle-less games or games without voice-overs)
-* Subtitle speed (disable in Simon1 CD)
-* Volume --> closely related to text and speech, so perhaps just disable speech volume for text-only games
-* SoundFont (no need to enable if game doesn't have MIDI music)
-* Mixed Adlib/MIDI (only couple games feature that)
-* True Roland (supported only by games with MT-32 tracks)
-* Roland GS (same as above)