Open main menu

Difference between revisions of "AGOS/TODO"

34 bytes removed ,  04:05, 10 April 2006
Be less obvious about which one is my own preferred bugfix. :-)
(Typo)
(Be less obvious about which one is my own preferred bugfix. :-))
Line 46: Line 46:


* Change the variables from unsigned to signed.
* Change the variables from unsigned to signed.
* Check for overflow when adding the width of the space. (I don't like this one myself, but that may be what it's trying to do already when checking if <tt>_printCharCurPos == _printCharMaxPos</tt>.)
* Check for overflow before adding the width of the space. (This may be what it's trying to do already by checking if <tt>_printCharCurPos == _printCharMaxPos</tt>.)
* Rewrite the test so that signedness doesn't matter, e.g. <tt>if (_printCharCurPos + count < _printCharMaxPos)</tt>
* Rewrite the test so that signedness doesn't matter, e.g. <tt>if (_printCharCurPos + count < _printCharMaxPos)</tt>


Oddly enough, the original ''does'' use unsigned variables, and take none of these precautions. Is it possible that the compiler ''Adventure Soft'' used behaved differently (buggily?), or are we missing some subtle detail...?
Oddly enough, the original ''does'' use unsigned variables, and take none of these precautions. Is it possible that the compiler ''Adventure Soft'' used behaved differently (buggily?), or are we missing some subtle detail...?
407

edits