Difference between revisions of "Sword25/TODO"

Jump to navigation Jump to search
992 bytes removed ,  16:36, 20 May 2011
The game should start again in locales which don't use decimal point.
(Added regressions section. It's more of a bug than a TODO, but it's too early to file bug reports.)
(The game should start again in locales which don't use decimal point.)
Line 6: Line 6:


== Regressions ==
== Regressions ==
* In locales that use decimal comma instead of decimal point, the game refuses to start with the following error message:
<source lang="text">
ERROR: Couldn't compile "@/system/cfg.lua"
/system/cfg.lua:173: malformed number near '0.5'!
</source>
The message is produced by trydecpoint() which contrary to the comment ''is'' used in ScummVM though only, it seems, if the first attempt at converting the string failed. See the read_numeral() function.
The simplest solution I can think of would be to change trydecpoint() to use ',' instead of '.', since it has presumably already tried '.'. But I don't know if that's sufficient. Perhaps there are other decimal separators that can still fit in a char? Slightly more elaborate, I guess we could try to format a known number to one decimal places and figure out the decimal separator from that.
The regression was almost certainly caused by 5f583eda0dbd09034ae44dd726b710a18d1aaec5, "SWORD25 (LUA): Removed unused non-portable locale code".


== TODOs ==
== TODOs ==
408

edits

Navigation menu