408
edits
Difference between revisions of "AGOS/TODO"
Jump to navigation
Jump to search
Typo
Eriktorbjorn (talk | contribs) (Updated my thoughts about the missing line breaks again. Mostly to correspond with the latest Simon engine changes.) |
Eriktorbjorn (talk | contribs) (Typo) |
||
| Line 47: | Line 47: | ||
* Change the variables from unsigned to signed. | * Change the variables from unsigned to signed. | ||
* Check for overflow when adding the width of the space. (I don't like this one myself, but that may be what it's trying to do already when checking if <tt>_printCharCurPos == _printCharMaxPos</tt>.) | * Check for overflow when adding the width of the space. (I don't like this one myself, but that may be what it's trying to do already when checking if <tt>_printCharCurPos == _printCharMaxPos</tt>.) | ||
* Rewrite the test so that signedness doesn't matter, e.g. <tt>if ( | * Rewrite the test so that signedness doesn't matter, e.g. <tt>if (_printCharCurPos + count < _printCharMaxPos)</tt> | ||
Oddly enough, the original ''does'' use unsigned variables, and take none of these precautions. Is it possible that the compiler ''Adventure Soft'' used behaved differently (buggily?), or are we missing some subtle detail...? | Oddly enough, the original ''does'' use unsigned variables, and take none of these precautions. Is it possible that the compiler ''Adventure Soft'' used behaved differently (buggily?), or are we missing some subtle detail...? | ||