208
edits
m (→During GSoC...) |
|||
Line 21: | Line 21: | ||
** ''The formatting conventions are one of the main ways we keep consistency with such a large codebase. We want students to work towards their code being incorporated into mainline ScummVM and this is a prerequisite.'' | ** ''The formatting conventions are one of the main ways we keep consistency with such a large codebase. We want students to work towards their code being incorporated into mainline ScummVM and this is a prerequisite.'' | ||
* ... you should at the very least verify that your '''code is compilable''' before you commit it. | * ... you should at the very least verify that your '''code is compilable''' before you commit it. | ||
** ''Checked in code does not have to be feature complete or anything like that but it should at least compile at all times. Mentors regularly review students' code and having to | ** ''Checked in code does not have to be feature complete or anything like that but it should at least compile at all times. Mentors regularly review students' code and having to spend hours making the code compile is a very thankless task ;) when that time could be better spent on review.'' | ||
* ... we expect you to '''commit often, commit early'''. | * ... we expect you to '''commit often, commit early'''. | ||
** ''We judge students' code based on what is checked in and take the view that 'if it's not checked in it does not exist' for the purposes of GSoC reviews. Don't be shy about this. You may feel your code is not 'good enough', but the best way to learn whether it actually is good or not, and also to get valuable hints on how to improve it, is to show it to us. Trust us, we will give you constructive feedback and won't bash you for what you produce.'' | ** ''We judge students' code based on what is checked in and take the view that 'if it's not checked in it does not exist' for the purposes of GSoC reviews. Don't be shy about this. You may feel your code is not 'good enough', but the best way to learn whether it actually is good or not, and also to get valuable hints on how to improve it, is to show it to us. Trust us, we will give you constructive feedback and won't bash you for what you produce.'' |
edits