415
edits
Difference between revisions of "Sword25/TODO"
Jump to navigation
Jump to search
As I said, I should have previewed it. Carefully.
Eriktorbjorn (talk | contribs) (Oops, I put that note in the wrong place. (Should have previewed it.)) |
Eriktorbjorn (talk | contribs) (As I said, I should have previewed it. Carefully.) |
||
| Line 16: | Line 16: | ||
* PersistenceService::saveGame and PersistenceService::loadGame contain code to (de)compress the save data using zlib. But we already compress savegames using zlib, so now we end up compressing them twice. Unless we need to do the compression to be compatible with saves from the original, we should get rid of this in-engine compression. If we can't get rid of it, we should add code comments that explain the reasons. | * PersistenceService::saveGame and PersistenceService::loadGame contain code to (de)compress the save data using zlib. But we already compress savegames using zlib, so now we end up compressing them twice. Unless we need to do the compression to be compatible with saves from the original, we should get rid of this in-engine compression. If we can't get rid of it, we should add code comments that explain the reasons. | ||
* The following commented out code used to be in kernel/scummvmwindow.cpp; I am keeping it here in case there is still something in there that needs to be handled (which I can't tell right now). | * The following commented out code used to be in kernel/scummvmwindow.cpp; I am keeping it here in case there is still something in there that needs to be handled (which I can't tell right now). | ||
* Locale-related bugs. One example, though there may be others: At the time of writing, the music volume gets set to 0 by default, probably because it misinterprets 0.5 (which in my locale is formatted as "0,5") as 0. The other default volumes are 1, and it probably interprets everything up to the decimal comma in those cases. (I'm not sure why | * Locale-related bugs. One example, though there may be others: At the time of writing, the music volume gets set to 0 by default, probably because it misinterprets 0.5 (which in my locale is formatted as "0,5") as 0. The other default volumes are 1, and it probably interprets everything up to the decimal comma in those cases. (I'm not sure why Sword25FileProxy::setupConfigFile() uses the default volumes, because I do have settings for them in my .scummvmrc.) | ||
<source lang="cpp"> | <source lang="cpp"> | ||
// FIXME: Special keys detected here need to be moved into the Input Engine | // FIXME: Special keys detected here need to be moved into the Input Engine | ||
// Die WindowProc aller Fenster der Klasse | // Die WindowProc aller Fenster der Klasse | ||