1,079
edits
Difference between revisions of "User:Fingolfin"
Jump to navigation
Jump to search
→Misc
(Updated my personal TODO list) |
(→Misc) |
||
| Line 60: | Line 60: | ||
=== Misc === | === Misc === | ||
* | * Follow some consistent naming patterns for functions/methods: | ||
** A method which return an object pointer and expects the calling code to delete the object after use, should be named makeFOO; so for example, FSNode::openForReading() would become FSNode::makeReadStream() | |||
** A method which is supposed to free/delete/dellocate something should have a consistent name. Maybe freeFOO? deallocFOO? destroyFOO? | |||
* Remove the 'addDefaultDirectory' calls from runGame in base/main.cpp. Reason: Their presence causes an asymmetry between the "detect a game" and "run a game" use cases, as different files are "seen" in each case. This can lead to subtle bugs, and also causes ugly code duplication in the AdvancedDetector code right now (there to work around asymmetries like this one) | * Remove the 'addDefaultDirectory' calls from runGame in base/main.cpp. Reason: Their presence causes an asymmetry between the "detect a game" and "run a game" use cases, as different files are "seen" in each case. This can lead to subtle bugs, and also causes ugly code duplication in the AdvancedDetector code right now (there to work around asymmetries like this one) | ||
* add plugin API to fetch a fresh desc string for a given target ?!? | * add plugin API to fetch a fresh desc string for a given target ?!? | ||