Difference between revisions of "Sword25/TODO"

Jump to navigation Jump to search
252 bytes removed ,  15:15, 25 October 2018
m
Text replacement - "<source lang=" to "<syntaxhighlight lang="
(Added note about locale-related bugs.)
m (Text replacement - "<source lang=" to "<syntaxhighlight lang=")
 
(6 intermediate revisions by 3 users not shown)
Line 15: Line 15:
* Audio does not get saved with Persistence
* Audio does not get saved with Persistence
* PersistenceService::saveGame and PersistenceService::loadGame contain code to (de)compress the save data using zlib. But we already compress savegames using zlib, so now we end up compressing them twice. Unless we need to do the compression to be compatible with saves from the original, we should get rid of this in-engine compression. If we can't get rid of it, we should add code comments that explain the reasons.
* PersistenceService::saveGame and PersistenceService::loadGame contain code to (de)compress the save data using zlib. But we already compress savegames using zlib, so now we end up compressing them twice. Unless we need to do the compression to be compatible with saves from the original, we should get rid of this in-engine compression. If we can't get rid of it, we should add code comments that explain the reasons.
* There may still be locale-related bugs. There have been at least two relating to the decimal mark being a comma instead of a point in my locale. However, there are currently no known ones.
* The following commented out code used to be in kernel/scummvmwindow.cpp; I am keeping it here in case there is still something in there that needs to be handled (which I can't tell right now).
* The following commented out code used to be in kernel/scummvmwindow.cpp; I am keeping it here in case there is still something in there that needs to be handled (which I can't tell right now).
<source lang="cpp">
 
* Locale-related bugs. One example, though there may be others: At the time of writing, the music volume gets set to 0 by default, probably because it misinterprets 0.5 (which in my locale is formatted as "0,5") as 0. The other default volumes are 1, and it probably interprets everything up to the decimal comma in those cases. (I'm not sure why Sword25FileProxy::setupConfigFile() uses the default volumes, because I do have settings for them in my .scummvmrc.)
<syntaxhighlight lang="cpp">
 
// FIXME: Special keys detected here need to be moved into the Input Engine
// FIXME: Special keys detected here need to be moved into the Input Engine
// Die WindowProc aller Fenster der Klasse
// Die WindowProc aller Fenster der Klasse
Line 150: Line 153:
     return 0;
     return 0;
}
}
</source>
</syntaxhighlight>


== Lua TODO ==
== Lua TODO ==
TrustedUser
2,147

edits

Navigation menu