Difference between revisions of "TsAGE/TODO"

From ScummVM :: Wiki
Jump to navigation Jump to search
(Added a possible scene 5300 bug.)
m (Minor cleanup of TsAGE TODOs)
 
(55 intermediate revisions by 6 users not shown)
Line 1: Line 1:
This is a list of things that still need to be handled properly for the Ringworld game:
{{Infobox_TODO|
*Add sound support
taskname=TsAGE Engine TODO|
**Adlib
techcontact=[[TsAGE]] Engine Team|
**Sound Blaster
subsystem=Engine|
**Midi (MT-32)
}}


Known engine bugs:
== Game status ==
* There's a Valgrind warning in SceneObject::removeObject() about _visage being undefined when it tests for it. ("Conditional jump or move depends on uninitialised value(s)".
* Ringworld Floppy version: Completable.
* The start play / introduction dialog looks a bit different in DOSBox than it does in ScummVM. It's positioned slightly different, the "Introduction" button has a different border (default button, perhaps?), and when clicked the button goes black, not red.
* Ringworld First wave version: Completable.
* In DOSBox, the button remains selected unless I move the mouse entirely off the button. (Should be fixed now, but the fix is a bit hackish.)
* Ringworld CD version: Completable.
* Quitting the game while the inventory dialog is open generates a failed assertion.


Known hardcoded logic bugs in floppy version:
* Blue Force Floppy version: Completable.
* In scene #6100, the Rocks occasionally get drawn on-screen over-sized at the very bottom of the screen. This is most easily noticable by navigating into a sunflower.
* Blue Force First wave version: Completable.
* Restoring a savegame in scene2320 results in a crash whenever the lift is used
* Blue Force CD version: Completable.
* Blue Force CD Spanish: Not supported.


Known hardcoded logic bugs in First Wave version:
* Return to Ringworld Demo: Completable.
*Scene 2320: When Quinn picks the arms, there a priority glitch (to be verified)
* Return to Ringworld CD: Completable.
*Scene 6100: At the end, texts are not skippable, it looks wrong (to be verified)


Known hardcoded logic bugs in CD version:
== Known Bugs ==
*Scene 2100: If you sit down at Quinn's console and then get back up again, his walk animation gets screwed up until you leave the scene. (Update: This still happens for me, even after the fix. Note that I just click on the floor to walk away from the seat. If I click to use the seat, the animation works as it should. I wasn't even aware I could do that before.)
Ringworld:
*Scene 4000 (or maybe 4045): If you tell the chief to show you the Tech, Miranda will say "Quinn, it's a simple force field regulator", even if she's not in the room with you because she's stuck with Rock. (Update: This is apparently a bug in the original interpreter as well, but could perhaps be fixed in ScummVM?)
* None.
*Scene 4100: If you enter from scene 4150 (the sleeping chamber/kitchen), and Rock is already passed out from the ale, the mouse cursor will stay invisible until you click the mouse.
*Scene 4025: Trying to save while looking at the "Tech" triggers an assertion: "engines/tsage/saveload.cpp:76: void tSage::Serializer::syncPointer(tSage::SavedObject**, Common::Serializer::Version, Common::Serializer::Version): Assertion `idx > 0' failed."
*Scene 2100: Talking to or looking at Miranda right after Seeker has been lost in the cave causes an "***I have no response.!" error. I guess that means that _globals->getFlag(59) didn't return 0 ("getflag 59" in the debugger prints 1). Forcing the flag to be 0 prints appropriate messages for the situation, but is it the condition or the value of the flag that is wrong? (The flag is set when the transmission ends and you leave scene 3700, and since that's when you find out that Seeker is lost, I'm guesing it's the test that's wrong. The flag is tested in a few others places, but those aren't necessarily wrong just because of that of course.)
*Scene 5300: This may not be a bug, but if I escape this room and are recaptured (by falling into the pit again), Quinn says "Was it something I said?", etc. Is he supposed to say that every time, or just the first time I get here?
*Scene 5300: After getting the stasis box, I returned to the food pit (by getting caught again) and spoke to Seeker. He didn't say anything, just walked over to beneath the opening and jumped up through it. Though solid rock, apparently, because it's still described as being covered by a rock. If I escape, and get caught again, Seeker is back in the pit. Otherwise, I don't know where he went.


Game status:
Blue Force:
*Floppy version: Completable.
* Game speed is much slower (~50%) compared to original interpreter running under DOSBox.
*First wave version: Completable.
* Map Cursor slow to appear and is not USE hand...
*CD version: status unknown
 
=== Present in the original game (Script Bugs) ===
Ringworld:
* Scene 2320: After being told to look for the Explorer I was able to construct the arms for the dolphin. I didn't even know I would need that!
* Scene 4000 (or maybe 4045): If you tell the chief to show you the Tech, Miranda will say "Quinn, it's a simple force field regulator", even if she's not in the room with you because she's stuck with Rock.
* Scene 5100: After stunning one of the flesheaters, the other one runs away. If you stun the one on the right, the other one hides on the far left of the scene. Even though you can't see it, you can examine it and touch it. The descriptions you get are the same as for the stunned flesheater. Apparently, the game doesn't make any difference between them.
* Scene 5300: If I escape this room and are recaptured (by falling into the pit again), Quinn says "Was it something I said?", etc. This happen until Quinn drinks the potion, so it looks a bit weird when it's not the first time.
* Scene 6100: If I allow the probe to get too damaged, it leads into a conversation between Quinn and Seeker. The mouse cursor is shown here (present in the original) and the cursor movement is much jerkier than usual. (This jerkiness is also present when successfully reaching the destination with the probe.)
* Scene 6100: At the end, texts are not skippable, it looks wrong
 
Blue Force:
* None
 
=== Possible Enhancements ===
 
* Currently only Adlib/Soundblaster is supported. It would be nice to support others, such as Roland or General Midi
 
* Rewrite the savegame mechanism
 
Currently the savegame code works similiar to the original, in that every object derives from a 'SavedObject' base, which is registered in a master list when objects that derive from it are instantiated. So the saving code essentially loops through the objects one by one to have each save their data in turn. The trouble with this it when loading a savegame, it relies on all the objects registered in the list to have been instantiated in the exact same order; which may not be the case if the savegame is loaded in another system, or even which an executable compiled using another compiler, since the fields of a given class are guaranteed to be created in the same order.
 
A lot of this could be resolved by replacing this with a manual hierarchnical saving of data, where the overall Globals object would explicitly call the synchronize method of all the objects within it, and they each explicitly call the method for the objects they contain, and so on. Whilst this would handle the majority of the save process, there is one remaining issue, that of pointer handling.
 
In many places in the engine there are pointers to other objects. The Sequence (Cutscene) manager can, for example, take in pointers for the characters the cutscene applies to. Currently these are handled by storing the index in the list of instantiated objects of the object the pointer points to, and then doing a lookup doing savegame restore. Because of this, it will be very difficult to get rid of the existing savegame mechanism without coming up with a good way to represent the same information. Perhaps giving any object that can be pointed to a unique Id, and having a lookup list of only those Ids. This might ensure savegame restore would work, and allow them to be portable.

Latest revision as of 12:51, 16 March 2016

TODO List
Name TsAGE Engine TODO
Technical Contact(s) TsAGE Engine Team
Subsystem Engine

Game status

  • Ringworld Floppy version: Completable.
  • Ringworld First wave version: Completable.
  • Ringworld CD version: Completable.
  • Blue Force Floppy version: Completable.
  • Blue Force First wave version: Completable.
  • Blue Force CD version: Completable.
  • Blue Force CD Spanish: Not supported.
  • Return to Ringworld Demo: Completable.
  • Return to Ringworld CD: Completable.

Known Bugs

Ringworld:

  • None.

Blue Force:

  • Game speed is much slower (~50%) compared to original interpreter running under DOSBox.
  • Map Cursor slow to appear and is not USE hand...

Present in the original game (Script Bugs)

Ringworld:

  • Scene 2320: After being told to look for the Explorer I was able to construct the arms for the dolphin. I didn't even know I would need that!
  • Scene 4000 (or maybe 4045): If you tell the chief to show you the Tech, Miranda will say "Quinn, it's a simple force field regulator", even if she's not in the room with you because she's stuck with Rock.
  • Scene 5100: After stunning one of the flesheaters, the other one runs away. If you stun the one on the right, the other one hides on the far left of the scene. Even though you can't see it, you can examine it and touch it. The descriptions you get are the same as for the stunned flesheater. Apparently, the game doesn't make any difference between them.
  • Scene 5300: If I escape this room and are recaptured (by falling into the pit again), Quinn says "Was it something I said?", etc. This happen until Quinn drinks the potion, so it looks a bit weird when it's not the first time.
  • Scene 6100: If I allow the probe to get too damaged, it leads into a conversation between Quinn and Seeker. The mouse cursor is shown here (present in the original) and the cursor movement is much jerkier than usual. (This jerkiness is also present when successfully reaching the destination with the probe.)
  • Scene 6100: At the end, texts are not skippable, it looks wrong

Blue Force:

  • None

Possible Enhancements

  • Currently only Adlib/Soundblaster is supported. It would be nice to support others, such as Roland or General Midi
  • Rewrite the savegame mechanism

Currently the savegame code works similiar to the original, in that every object derives from a 'SavedObject' base, which is registered in a master list when objects that derive from it are instantiated. So the saving code essentially loops through the objects one by one to have each save their data in turn. The trouble with this it when loading a savegame, it relies on all the objects registered in the list to have been instantiated in the exact same order; which may not be the case if the savegame is loaded in another system, or even which an executable compiled using another compiler, since the fields of a given class are guaranteed to be created in the same order.

A lot of this could be resolved by replacing this with a manual hierarchnical saving of data, where the overall Globals object would explicitly call the synchronize method of all the objects within it, and they each explicitly call the method for the objects they contain, and so on. Whilst this would handle the majority of the save process, there is one remaining issue, that of pointer handling.

In many places in the engine there are pointers to other objects. The Sequence (Cutscene) manager can, for example, take in pointers for the characters the cutscene applies to. Currently these are handled by storing the index in the list of instantiated objects of the object the pointer points to, and then doing a lookup doing savegame restore. Because of this, it will be very difficult to get rid of the existing savegame mechanism without coming up with a good way to represent the same information. Perhaps giving any object that can be pointed to a unique Id, and having a lookup list of only those Ids. This might ensure savegame restore would work, and allow them to be portable.