Difference between revisions of "User talk:David corrales"

Jump to navigation Jump to search
Added the FSNode method call table
(Added the FSNode use cases)
(Added the FSNode method call table)
Line 61: Line 61:
-) removed the include and compilation went fine. Don't see any forward declarations.
-) removed the include and compilation went fine. Don't see any forward declarations.


* '''engines/scumm/plugin.cpp'''
* '''engines/scumm/detection.cpp'''
1) searchFSNode(FSList, String, FilesystemNode): searches for a node within a list using an iterator. As discussed earlier, this could be moved into the FSNode class.
1) searchFSNode(FSList, String, FilesystemNode): searches for a node within a list using an iterator and name(). As discussed earlier, this could be moved into the FSNode class.


2) detectLanguage(FSList, byte id): calls searchFSNode(). Also uses isDirectory(), listDir(kListFilesOnly).
2) detectLanguage(FSList, byte id): calls searchFSNode(). Also uses isDirectory(), listDir(kListFilesOnly).
Line 81: Line 81:


* '''engines/agi/agi_v3.cpp'''
* '''engines/agi/agi_v3.cpp'''
1) detectGame(): creates a FSList using listDir(kListFilesOnly). name()
1) detectGame(): creates a FSList using listDir(kListFilesOnly). name().


* '''engines/sky/sky.cpp'''
* '''engines/sky/sky.cpp'''
Line 134: Line 134:
* '''backends/fs/ds/ds-fs.h|cpp''' (duplicate include)
* '''backends/fs/ds/ds-fs.h|cpp''' (duplicate include)


=== Method usage table ===
The following table is a rough estimate of the usage made by calling classes. It's meant to be a help when deciding what to change and which new methods could help the most.
{| border="1" cellpadding="5" cellspacing="0"
!Operation
!Calls
!Percentage
|-
|displayName()
|1
|1,81%
|-
|name()
|10
|18,18%
|-
|path()
|10
|18,18%
|-
|getChild()
|0
|0%
|-
|listDir()
|19
|34,54%
|-
|isDirectory()
|12
|21,81%
|-
|isValid()
|2
|3,63%
|-
|getParent()
|1
|1,81%
|-
|'''Total'''
|55
|100%
|}


== Common::File redesign discussion ==
== Common::File redesign discussion ==

Navigation menu