265
edits
Difference between revisions of "Developer Central"
Jump to navigation
Jump to search
m
Add Tools section
Strangerke (talk | contribs) (→Code statistics: Remove obsolete links, add github) |
Dreammaster (talk | contribs) m (Add Tools section) |
||
| (27 intermediate revisions by 11 users not shown) | |||
| Line 4: | Line 4: | ||
* The first thing you need to be able to do is [[Git#Retrieving_the_code|get the ScummVM code]] from our [[Git]] repository. | * The first thing you need to be able to do is [[Git#Retrieving_the_code|get the ScummVM code]] from our [[Git]] repository. | ||
* Then you should [[Compiling ScummVM|compile ScummVM]]. | * Then you should [[Compiling ScummVM|compile ScummVM]]. | ||
* If you are new to open source, you can also try reading https://opensource.guide/how-to-contribute/ | |||
* Then read [[#Help! Where do I start with the code base?|Help! Where do I start with the code base?]] | |||
That was easy, right? Here are some more tips: | That was easy, right? Here are some more tips: | ||
* Some hints on [[Debugging ScummVM|debugging ScummVM]]. | * Some hints on [[Debugging ScummVM|debugging ScummVM]]. | ||
* Before you write/submit code, '''you must read | * Before you write/submit code, '''you must read''' our [[Code Formatting Conventions]].<br>Patches which do not follow them will be rejected or at least delayed until they are cleaned up to comply to them. | ||
* Also, you should read and respect the general [[Coding Conventions]]. | * Also, you should read and respect the general [[Coding Conventions]]. | ||
* If you have write access to our repository, you are expected to have read and to comply with our [[Commit Guidelines]]. Also, read | * Our [https://bugs.scummvm.org bug tracker] might provide some easy tasks to start with and familiarise yourself with the ScummVM code base. | ||
* If you do not have write access, you should | * If you have write (push) access to our repository, you are expected to have read and to comply with our [[Commit Guidelines]].<br>Also, please read the tips for using Git here: [[Git tips]].<br>In particular, note the use of feature branches, when working on refactoring or other large connected changes, rather than committing directly to scummvm/master. | ||
* If you do not have write (push) access to our repository, you should submit your contributions by one of the following methods: | |||
** Using a [https://help.github.com/articles/using-pull-requests Github Pull Request].<br> This requires you to have/register a github account, fork our repository, commit your changes to a branch and then issue a Pull Request.<br>This is the current preferred method as it is easier for the team to review, discuss and amend prior to merging.<br>You are expected to have read and to comply with our [[Commit Guidelines]]. | |||
** Using the [https://bugs.scummvm.org/ patch tracker].<br>This requires you to have/register a github account, and generate a [https://en.wikipedia.org/wiki/Patch_%28Unix%29 patch] file, but this may be easier for developers unfamilar with Git or for small single commit changes, where a Pull Request might be considered overkill. | |||
** If neither of the above methods are suitable, individual developers may be willing to accept patches or amended source files by other methods i.e. e-mail, but please ask in the project IRC channel or by e-mail before doing this. | |||
* Our [http://doxygen.scummvm.org/ Doxygen source code documentation] may help you to get the big picture about ScummVM. | * Our [http://doxygen.scummvm.org/ Doxygen source code documentation] may help you to get the big picture about ScummVM. | ||
* Also, you might want to check our list for current [[Platform Limitations]]. | * Also, you might want to check our list for current [[Platform Limitations]]. | ||
== Help! Where do I start with the code base? == | |||
=== Code base structure === | |||
The ScummVM code base is quite big, but well structured with five main components: | |||
{| class="wikitable" | |||
! style="text-align:left;"|Component | |||
! Source code location | |||
|- | |||
| The OSystem API, which defines available features a game can use, such a drawing on screen or receiving keyboard and mouse events. | |||
|common/system.h | |||
|- | |||
|The backends, which implement the OSystem API for various platforms. | |||
|backends/ | |||
|- | |||
|The game engines. | |||
|engines/ | |||
|- | |||
|Common code, that provides various utility classes (for example containers) and audio, image, and video codecs that game engines can use. | |||
|common/<br>audio//<br>image/<br>video/ | |||
|- | |||
|Gui code, that provides a graphical user interface for the game launcher and options dialog. | |||
|gui/ | |||
|} | |||
And then you have a few more directories: | |||
* base/ | |||
: This is the entry point for the application. It for example handles command line argument parsing and the main loop. See [[#Entry points|Entry points]] below. | |||
*test/ | |||
: Contains unit tests for some utility classes from the common code. | |||
* po/ | |||
: Contains translation of the ScummVM GUI into various languages | |||
=== First steps === | |||
The OSystem API shields game engines and gui code from the actual platform the software is running on. The backends code is the only part of the code base that is platform dependent. So if you want to work on a game engine for example you will need to look at the OSystem API to know what you can do in the engine, but you can ignore everything in the backends code as you don't need to know how the OSystem API is actually implemented. On the other hand if you wand to port ScummVM to a new platform, the backends code is what you will want to look at. | |||
You can start by browsing a bit the source code to see how it maps to the description above, and then depending on your interests select one piece of code to look at in more details. For example if you are interested in ports, look at how one specific port is implemented. Or if you are interested in game engines, look at one engine. | |||
In you are interested in game engines, the <code>plumber</code> engine is the simplest one by far, and you can start from there to see the overall structure of an engine. Then you can select an engine for one of the free games we have on our [https://www.scummvm.org/games/ download page] (for example [https://www.scummvm.org/games/#queen Flight of the Amazon Queen], with the corresponding engine source code in <code>engines/queen/</code>), or a game you already own. You can make changes and see how it behaves, run the engine with a debugger, and use an hexadecimal editor to look at the game data file and map them to what the engine does. At first you can in particular look at the engine's use of the classes in the common/ folder, such as Common::File, Common::Array. Start getting a feel for what classes are available before you move onto the graphic and event handling stuff. | |||
If you interest lies with ports and how ScummVM interacts with various operating systems, take a look at the source code in <code>backends/</code>. There are two main categories of backends: monolithique ones and modular ones. The modular backends split the OSystem API implementation between several modules, the GraphicsManager being maybe the most important. Most modular backends use the [https://www.libsdl.org SDL library] and share some code between them. | |||
Our [http://doxygen.scummvm.org doxygen documentation] might help to grasp class hierarchy and navigate the source code at first. In particular it provides a visual representation of the relationship between classes. Using an IDE such as Visual Studio, Xcode, Eclipse, QtCreator or CLion can also be a big help. See the create_project tool to generate projects for various IDE. | |||
Once you are no longer completely lost and have a grasp of the code base structure, a good way to dive deeper might be to find a task to work on. You can have a look at the [https://bugs.scummvm.org bug tracker] and the various TODO lists on this wiki. See the [[Developer_Central#Projects, plans, things to do|Projects, plans, things to do]] section. Once you have a sense of something concrete you want to work on, you are highly encourage to visit our IRC channel (#scummvm on freenode) where you can ask for helps and guidance from fellow developers. | |||
=== Entry points === | |||
# The executable entry point varies depending on the platforms (and therefore it is in <code>backends/</code>). For example for Linux you will find it in <code>backends/platform/sdl/posix/posix-main.cpp</code> while for macOS it is in <code>backends/platform/sdl/macosx/macosx-main.cpp</code>. | |||
# From there it goes into the actual ScummVM main entry point, <code>scummvm_main()</code> implemented in <code>base/main.cpp</code>. | |||
# It alternates between showing the Game Launcher and running a game. | |||
## While the GUI is running (in the game launcher or options dialog) the main loop is <code>GuiManager::runLoop()</code> in <code>gui/gui-manager.cpp</code>. | |||
## Each game engine has its own entry point, which is its implementation of the pure virtual <code>Engine::run()</code> function. | |||
== Pull Request approval process == | |||
The current procedure is as follow: | |||
# For a sizeable, significant changes it is advised to make a [https://help.github.com/articles/about-pull-requests/ Pull Request on GitHub]. | |||
# Such Pull Request will have to stay for at least 2 weeks open for the comments. | |||
# Everyone is invited to comment and review and voice their opinion (views of non-team members are valuable, but have no decisive power). | |||
# If there are no unaddressed objections after 2 weeks, the PR could be merged. Exception could be made if there are suggestions over refactoring or tidying up the code, granted that they will be addressed in-tree. | |||
# Immediately after the merge the PR maker ensures that the [http://buildbot.scummvm.org buildbot] stays happy and is not worsened (historically we had few ports broken for months). | |||
The definition of what makes a sizeable changes not cast in stone. This is up to the discretion of the PR creator, but normally we would expect that anything which breaks existing OSystem API and the Common code, or significantly extends these, especially if it requires more work from the Porters, should go via a Pull Request process. The goal is to ensure that everything stays maintainable. | |||
Any developer is free to open a PR for less significant changes, and that process could be used for facilitating the discussion and collecting feedback, but when there are no big changes involved, no 2 weeks timeout is enforced. | |||
Individual engine sub-teams decide by themselves on the process. For example currently the SCI development is performed via PRs as well for any sizeable changes. It is up to that sub-team to drop this rule any time or make something even stricter. Just make sure you continue enjoying hacking the ScummVM code. | |||
== For Engine authors == | == For Engine authors == | ||
| Line 20: | Line 91: | ||
* If your engine supports multiple games / game variants, properly detecting and differentiating them all can be a nuisance. Use the [[Advanced Detector]] to overcome this hurdle. | * If your engine supports multiple games / game variants, properly detecting and differentiating them all can be a nuisance. Use the [[Advanced Detector]] to overcome this hurdle. | ||
* Accessing files in a portable fashion is non-trivial. Read all about [[HOWTO-Open_Files|how to open files]]. | * Accessing files in a portable fashion is non-trivial. Read all about [[HOWTO-Open_Files|how to open files]]. | ||
* Debugging endian issues can be tricky. [[HOWTO-Debug-Endian-Issues |This page]] gives some solutions. | |||
* If you want to have your engine merged into the ScummVM mainline, check out our [[HOWTO-Engine_Inclusion|Engine Inclusion HOWTO]]. | |||
* For those starting out with reverse engineering, check out our [[HOWTO-Reverse_Engineering|Reverse Engineering HOWTO]]. | |||
* Apart from git bisection to locate regressions in gameplay, the (experimental) [[Event_Recorder|Event Recorder]] provides a framework for recording and replaying gameplay to detect regressions. | |||
* For some general suggestions on developing engines, see the [[HOWTO-Tips_And_Tricks|Engine Development Tips & Tricks]] | |||
== For Backend authors == | == For Backend authors == | ||
| Line 26: | Line 102: | ||
== For Web site maintainers == | == For Web site maintainers == | ||
If you want to update the main web site: | |||
* Update the files you want in the scummvm-web project | |||
* Trigger http://www.scummvm.org/site-update/ URL. (Ask sev for an account) | |||
* This is also covered in more detail by the relevant section of the Admin HOWTO [[HOWTO-Admin#How_to_edit.2Fupdate_webpages|here]]. | |||
== Projects, plans, things to do == | == Projects, plans, things to do == | ||
We are usually happy to receive any kind of help with the things listed below. | We are usually happy to receive any kind of help with the things listed below. | ||
* [[OpenTasks|List of open tasks]], with relatively detailed descriptions, and contact points. Some rather small ones, some bigger ones, take a look. | * [[OpenTasks|List of open tasks]], with relatively detailed descriptions, and contact points. Some rather small ones, some bigger ones, take a look. [[GSoC Ideas]] also has some ideas, intended for students applying for Google's Summer of Code. | ||
* [[TODO|Main TODO list]] (contains links to many further specialized TODO pages, e.g. for specific engines). | * [[TODO|Main TODO list]] (contains links to many further specialized TODO pages, e.g. for specific engines). | ||
* Our [ | * Our [https://bugs.scummvm.org/ bug tracker] lists bugs that need to be resolved and also lists features requested by all kinds of people. | ||
The following are partially outdated, but kept for now for the sake of reference. | The following are partially outdated, but kept for now for the sake of reference. | ||
| Line 44: | Line 122: | ||
* [[GUI Themes]] | * [[GUI Themes]] | ||
* [[GUI Themes/Specs|GUI Theme Specs]] | * [[GUI Themes/Specs|GUI Theme Specs]] | ||
* [[Supporting_GUI_Translation|GUI Translation Support]] | * [[Supporting_GUI_Translation|GUI Translation Support]] in code | ||
* [[HOWTO-Translate_ScummVM_GUI|Translation HOWTO]] for translation authors | |||
* [[GUI Themes/TODO|GUI TODO]] | * [[GUI Themes/TODO|GUI TODO]] | ||
== Networking == | |||
* [[Cloud Storage Support | Cloud Storage Support]] | |||
* [[Local Webserver | Local Webserver]] | |||
== Release Management == | == Release Management == | ||
* Our release guideline for ScummVM [[HOWTO-Release |Release HOWTO]] | * Our release guideline for ScummVM [[HOWTO-Release |Release HOWTO]] | ||
* Our release testing status for the latest stable release [[Release_Testing |Release Testing]] | * Our release testing status for the latest stable release [[Release_Testing |Release Testing]] | ||
* Anyone who wishes to bundle ScummVM with games for legal commercial and non-commercial release should read the notes [[Bundling_ScummVM|here]]. | |||
== Code statistics == | == Code statistics == | ||
Our commit logs are fed to several freely available statistics tools: | Our commit logs are fed to several freely available statistics tools: | ||
* [ | * [https://www.openhub.net/p/113 OpenHub project analysis] nice graphs and devs activity | ||
* [http://cia.vc/stats/project/ScummVM CIA.vc statistics], current development | * [http://cia.vc/stats/project/ScummVM CIA.vc statistics], current development | ||
* [http://github.com/scummvm], current development on github | * [http://github.com/scummvm GitHub page], current development on github | ||
== Team Member Benefits == | == Team Member Benefits == | ||
Every active ScummVM Team member is eligible for enhanced access to our [[Project Services]] and some further benefits: | Every active ScummVM Team member is eligible for enhanced access to our [[Project Services]] and some further benefits: | ||
* being added to our main credits (do it by yourself in scummvm/ | * being added to our main credits (do it by yourself in scummvm/devtools/credits.pl) | ||
* @scummvm.org forwarding address | * @scummvm.org forwarding address | ||
* operator status in our [[IRC Channel]] #scummvm @ freenode | * operator status in our [[IRC Channel]] #scummvm @ freenode | ||
| Line 68: | Line 152: | ||
* using project donations for purchasing necessary things for the development, such as game copies, software licenses, etc. | * using project donations for purchasing necessary things for the development, such as game copies, software licenses, etc. | ||
If you need any of the above, talk to [[User: | If you need any of the above, talk to [[User:Sev|sev]]. | ||
If you do admin tasks e.g. responding to bugs, moderating the forums, you should read the Admin HOWTO [[HOWTO-Admin|here]] for tips and guidelines on doing this. | |||
== Tools == | |||
* [https://www.scummvm.org/frs/extras/IDA/idafree50.exe IDA Freeware Version 5.0] - IDA is the preferred tool for disassembling old games from scratch. The most recent freeware version no longer supports disassembling DOS games, but this earlier version still supports it. | |||
== Misc == | == Misc == | ||
* [ | * List of [[Defines]] used in the source code. | ||
* Documentation on how we performed our [[CVS2SVN|CVS to Subversion]] conversion. | * Documentation on how we performed our [[CVS2SVN|CVS to Subversion]] conversion. | ||
* Old page listing [[CVS vs SVN|pros and cons between CVS and SVN]] before the conversion was made. | * Old page listing [[CVS vs SVN|pros and cons between CVS and SVN]] before the conversion was made. | ||
* A guide on submitting [[Screenshots]] for use on our website. | * A guide on submitting [[Screenshots]] for use on our website. | ||